-
Notifications
You must be signed in to change notification settings - Fork 51
docs: better explain the architecture and more clearly separate docker setup from lndmon setup (mermaid version) #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: better explain the architecture and more clearly separate docker setup from lndmon setup (mermaid version) #124
Conversation
|
Looks like it doesn't render well in GitHub "dark mode". Is that an issue for all mermaid charts? |
saubyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Regarding the rendering of mermaid charts in dark mode, you can look up suggestions on any of the LLM tools, it may be improved marginally.
I iterated a lot to improve the mermaid chart on this doc, if it's any help: https://github.com/lightningnetwork/lnd/blob/master/docs/db_migration_guide.md
| @@ -1,88 +0,0 @@ | |||
| # Table of Contents | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove install.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I changed the name is because the general install stuff was mostly moved to README.md and everything else related was docker specific.
Roasbeef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Favor keeping the name of INSTALL.md, but general doc improvement I'd say. You can get the diagram to render better in dark mode by using different colors.
…r setup from lndmon setup
41df9e2 to
2d12e2a
Compare
|
Force pushed a commit that removes a few lines that were added by the web mermaid chart editor I was using. The colors now look good in both light and dark mode. |
The reason I changed the name is because the general install stuff was mostly moved to |
This is an alternative to #123 that uses mermaid charts instead of https://app.monosketch.io to diagram the monitoring architecture.
@Roasbeef , @saubyk , @djkazic , please take a look!