-
Notifications
You must be signed in to change notification settings - Fork 122
build: bump deps #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build: bump deps #1021
Conversation
Summary of ChangesHello @GeorgeTsagk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant dependency upgrade, primarily bumping the versions of LND and tapd (Taproot Assets Daemon) along with their transitive dependencies. This update is essential to ensure compatibility and enable the compilation of the latest tap-channel integration tests. A minor code adjustment was also made to align with LND's refactored payment error handling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps several dependencies, most notably LND to v0.20.0-beta.rc1
. The changes in go.mod
and go.sum
reflect these updates. The modification in loopout.go
is a necessary adaptation to a change in LND where ErrAlreadyPaid
was moved from the channeldb
package to payments/db
. The change is correct and allows the project to compile with the new LND version. The author correctly notes that this PR includes release candidate tags, which is a consideration for merging into the master
branch. Overall, the changes look good and are consistent with the goal of updating dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Bumps LND and tapd (and some more indirect dependencies).
Needed for the latest tap-channel LiT itests to compile.
If we don't want to land this on
master
(since it includes rc tags) we can also land it on a side branch and use that for LiT.