Skip to content

Conversation

GeorgeTsagk
Copy link
Member

Description

Bumps LND and tapd (and some more indirect dependencies).

Needed for the latest tap-channel LiT itests to compile.

If we don't want to land this on master (since it includes rc tags) we can also land it on a side branch and use that for LiT.

@GeorgeTsagk GeorgeTsagk self-assigned this Oct 13, 2025
Copy link

Summary of Changes

Hello @GeorgeTsagk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant dependency upgrade, primarily bumping the versions of LND and tapd (Taproot Assets Daemon) along with their transitive dependencies. This update is essential to ensure compatibility and enable the compilation of the latest tap-channel integration tests. A minor code adjustment was also made to align with LND's refactored payment error handling.

Highlights

  • Core Dependency Bumps: Updated LND to v0.20.0-beta.rc1 and taproot-assets (tapd) to v0.7.0-rc1, which are crucial for compatibility with the latest tap-channel integration tests.
  • Database and Client Updates: Key dependencies such as btcwallet were bumped to v0.16.17, lndclient to v0.20.0-1, and pgx/v5 to v5.7.4.
  • LND Internal Refactoring Alignment: Adjusted loopout.go to reflect a change in LND's internal structure, specifically moving the ErrAlreadyPaid error from channeldb to payments/db.
  • Broader Ecosystem Updates: Numerous other indirect dependencies, including go.etcd.io/bbolt and several golang.org/x modules, were also updated to their latest versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps several dependencies, most notably LND to v0.20.0-beta.rc1. The changes in go.mod and go.sum reflect these updates. The modification in loopout.go is a necessary adaptation to a change in LND where ErrAlreadyPaid was moved from the channeldb package to payments/db. The change is correct and allows the project to compile with the new LND version. The author correctly notes that this PR includes release candidate tags, which is a consideration for merging into the master branch. Overall, the changes look good and are consistent with the goal of updating dependencies.

Copy link
Collaborator

@starius starius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@hieblmi hieblmi self-requested a review October 13, 2025 16:30
Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants