staticaddr: reduce deposit confs from 6 to 3

[hieblmi]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly lowers the minimum block confirmation threshold for deposits within the staticaddr module. By reducing the required confirmations from six to three, the change aims to accelerate the availability of deposited funds for subsequent operations such as loop-ins, cooperative spends, and timeouts, thereby improving efficiency and responsiveness.

Highlights

• Deposit Confirmation Reduction: The minimum number of block confirmations required for deposits has been reduced from 6 to 3.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request reduces the MinConfs constant from 6 to 3. This change will allow deposits to be considered available for subsequent operations (loop-ins, coop-spends, and timeouts) after only 3 confirmations instead of 6. While this improves efficiency by speeding up deposit processing, it significantly lowers the security threshold for these operations.

[gemini-code-assist]

Reducing MinConfs from 6 to 3 significantly lowers the security margin for deposits. This increases the risk of transactions being reversed due to blockchain reorgs, potentially affecting the reliability of subsequent loop-ins, coop-spends, and timeouts. A 3-confirmation threshold is generally considered less secure for high-value transactions compared to 6 confirmations.