Skip to content

loop: Global flags to accept ENV vars overrides. #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhandras merged 1 commit into from
Apr 1, 2025
Merged

loop: Global flags to accept ENV vars overrides. #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions cmd/loop/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,26 +51,30 @@ var (
defaultInitiator = "loop-cli"

loopDirFlag = cli.StringFlag{
Name: "loopdir",
Value: loopd.LoopDirBase,
Usage: "path to loop's base directory",
Name: "loopdir",
Value: loopd.LoopDirBase,
Usage: "path to loop's base directory",
EnvVar: envVarLoopDir,
}
networkFlag = cli.StringFlag{
Name: "network, n",
Usage: "the network loop is running on e.g. mainnet, " +
"testnet, etc.",
Value: loopd.DefaultNetwork,
Value: loopd.DefaultNetwork,
EnvVar: envVarNetwork,
}

tlsCertFlag = cli.StringFlag{
Name: "tlscertpath",
Usage: "path to loop's TLS certificate",
Value: loopd.DefaultTLSCertPath,
Name: "tlscertpath",
Usage: "path to loop's TLS certificate",
Value: loopd.DefaultTLSCertPath,
EnvVar: envVarTLSCertPath,
}
macaroonPathFlag = cli.StringFlag{
Name: "macaroonpath",
Usage: "path to macaroon file",
Value: loopd.DefaultMacaroonPath,
Name: "macaroonpath",
Usage: "path to macaroon file",
Value: loopd.DefaultMacaroonPath,
EnvVar: envVarMacaroonPath,
}
verboseFlag = cli.BoolFlag{
Name: "verbose, v",
Expand Down Expand Up @@ -116,6 +120,13 @@ const (
// prints out as,
// Conf target: 9 block
blkFmt = "%-36s %12d block\n"

// Environment variables names that can be used to set the global flags.
envVarRPCServer = "LOOPCLI_RPCSERVER"
envVarNetwork = "LOOPCLI_NETWORK"
envVarLoopDir = "LOOPCLI_LOOPDIR"
envVarTLSCertPath = "LOOPCLI_TLSCERTPATH"
envVarMacaroonPath = "LOOPCLI_MACAROONPATH"
)

func printJSON(resp interface{}) {
Expand Down Expand Up @@ -156,9 +167,10 @@ func main() {
app.Usage = "control plane for your loopd"
app.Flags = []cli.Flag{
cli.StringFlag{
Name: "rpcserver",
Value: "localhost:11010",
Usage: "loopd daemon address host:port",
Name: "rpcserver",
Value: "localhost:11010",
Usage: "loopd daemon address host:port",
EnvVar: envVarRPCServer,
},
networkFlag,
loopDirFlag,
Expand Down