Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: create StreamHandler RFQ service (send/recv lnd custom msg) #766

Closed
ffranr opened this issue Jan 15, 2024 · 3 comments · Fixed by #767
Closed

[feature]: create StreamHandler RFQ service (send/recv lnd custom msg) #766

ffranr opened this issue Jan 15, 2024 · 3 comments · Fixed by #767
Assignees
Labels
enhancement New feature or request rfq

Comments

@ffranr
Copy link
Contributor

ffranr commented Jan 15, 2024

Parent issue: #683

In this issue we will add the functionality necessary to subscribe and receive request for quote (RFQ) messages from LND. These messages will be passed between tapd peers via their lnd instances.

This work will involve the creation of a RfqStream component:

This module will use the SendCustomMessage and SubscribeCustomMessages [LND] RPC calls to funnel the RFQ messages (which use the custom message range) to the RfqNegotiator. It should maintain book keeping to keep track of the RfqNegotiator instance for all the active assets the daemon cares about at the time. It'll also need to properly map the requests to responses as well (see the rfq_id value in the messages).

The goal of this issue is to get to a point where we can write integration tests that send and receive RFQ messages via LND.

@ffranr ffranr added enhancement New feature or request rfq labels Jan 15, 2024
@ffranr ffranr self-assigned this Jan 15, 2024
@ffranr ffranr moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Jan 15, 2024
@ffranr
Copy link
Contributor Author

ffranr commented Jan 16, 2024

I'm going to use 20116 as the custom message type. Index positions of letters "t", "a", and "p" concatenated.

@ffranr
Copy link
Contributor Author

ffranr commented Jan 17, 2024

I noticed that LND sends custom messages with low priority and lazily:
https://github.com/lightningnetwork/lnd/blob/e7687005141701b9a609d12d53a0e84c713370a9/server.go#L4687-L4687

We might want to consider adding message priority customisation to the SendCustomMessage LND RPC endpoint so that we can better ensure timely tap RFQ message exchange.

@ffranr ffranr changed the title [feature]: send/recieve RFQ messages via LND [feature]: create StreamHandler RFQ service (send/recv lnd custom msg) Feb 1, 2024
@ffranr
Copy link
Contributor Author

ffranr commented Feb 1, 2024

Spun out the wire messages into a new issue: #780

@ffranr ffranr moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Feb 29, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rfq
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant