itest: universe server harness uses a dedicated LND node #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we ensure that the universe server harness uses a new dedicated LND node. The universe harness previously used the Bob standby LND node. This change allows us to use an in-test tapd node with LND node Bob without conflicting with the universe server tapd node. This change will be important when passing messages between tapd nodes (e.g. RFQ system) via LND nodes.
guggero
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
LGTM 🎉
I think it makes sense to use a specific node for the universe.
But I'd still say that for a test where we require a small test network of three nodes it would make sense to spin up three extra lnds, just to make sure we don't "pollute" the long-running nodes with channel state (which might have an impact on other tests).
GeorgeTsagk
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
LGTM
Just to make sure, this new harness node is introduced here in order to be used in future itests that require it to be a separate node? Are we going to also update all existing itests to use the uniServerLndHarness instead of Bob?
Edit: this seems to be part of the setup code, so effectively it affects current itest too I suppose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we ensure that the universe server harness uses a new dedicated LND node. The universe harness previously used the Bob standby LND node. This change allows us to use an in-test tapd node with LND node Bob without conflicting with the universe server tapd node.
This change will be important when passing messages between tapd nodes (e.g. RFQ system) via LND nodes.
This work is necessary to complete: #766