Refactor fundGenesisPsbt and enhance test helpers for coverage
#1418
+251
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
added
unit-test
supply commit
Pull Request Test Coverage Report for Build 18406524442Details
💛 - Coveralls |
ffranr
force-pushed
the
unit-tests-mint-pre-commit
branch
from
d41d194 to
83ba31c
Compare
ffranr
force-pushed
the
unit-commitment-mint-output
branch
2 times, most recently
from
a2263f6 to
cef2567
Compare
|
Needs rebase. |
ffranr
force-pushed
the
unit-tests-mint-pre-commit
branch
from
83ba31c to
11aeea1
Compare
ffranr
changed the title
fundGenesisPsbt and add high-level batch funding tests
ffranr
changed the title
fundGenesisPsbt and add high-level batch funding testsfundGenesisPsbt and enhance test helpers for coverage
Separate the mint anchor transaction fee rate calculation from fundGenesisPsbt into anchorTxFeeRate. This refactor is part of a broader effort to simplify calling fundGenesisPsbt from unit tests.
Extract the wallet funding call into a closure that is passed as an argument. This prepares fundGenesisPsbt to become a standalone function, making it easier to call in unit tests.
Pass the pending batch and chain params into fundGenesisPsbt and convert it into a standalone function rather than a method on ChainPlanter. This change makes it easier to call fundGenesisPsbt from unit tests.
The batch key was only used for logging. This commit moves the log messages outside fundGenesisPsbt, simplifying the function for better code health.
ffranr
force-pushed
the
unit-tests-mint-pre-commit
branch
from
11aeea1 to
e2e3f79
Compare
jtobin
approved these changes
Oct 10, 2025
The mock helper FundGenesisTx now returns the index of the change output. It also dynamically computes the index of the change output it adds. These enhancements will be useful when handling packets with supply pre-commitment outputs.
The funding routine now uses the refactored fundGenesisPsbt function, introduced in a previous commit. Which adds test coverage for the batch funding logic. An optional argument is also added to allow skipping funding.
RandSeedlingMintingBatch retires.
ffranr
force-pushed
the
unit-tests-mint-pre-commit
branch
from
e2e3f79 to
10b3fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines
fundGenesisPsbtinto a simpler, testable entry point and factors out ancillary logic to reduce coupling. Batch funding flows are exercised via updated unit test helpers, improving coverage and confidence around mint pre-commit scenarios. The mint batch helpers and mocks are aligned with the new shape, and the older seedling batch helper is retired. No behavioural changes are intended beyond improved structure and testability.