-
Notifications
You must be signed in to change notification settings - Fork 138
itest: run lnd backend in remote-signing mode #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 19930111150Details
💛 - Coveralls |
e62df0f to
f200946
Compare
|
With |
f1b456f to
1e4f9ea
Compare
jtobin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 👍
1e4f9ea to
1e2cb4a
Compare
1e2cb4a to
1da61fd
Compare
|
I've rebased this, as it seems easy enough to resurrect and review otherwise. Unsure we actually want to run w/remote signing mode in CI, though. |
1da61fd to
e45ed66
Compare
This commit adds a new flag to the integration test suite that starts the single lnd node (alice) either in normal or in remote-signing mode. In remote-signing mode, alice is actually a watch-only node that is connected to a seconardy signer node over RPC.
To make sure `tapd` works when the connected `lnd` node is running in remote-signing mode, we add a new CI target that runs all integration tests in that mode.
e45ed66 to
0fec22a
Compare
|
@GeorgeTsagk: review reminder |
Depends on btcsuite/btcwallet#1022 and then lightningnetwork/lnd#10119 which will hopefully make it into
lnd v0.19.3-beta.Created this itest to reproduce lightninglabs/lightning-terminal#1123.
Further investigation then lead to the creation of this bug report issue: lightningnetwork/lnd#10120
So this test will not succeed until lightningnetwork/lnd#10120 is fixed. But putting up the PR as a draft as we should aim to fix that issue and then have these tests run in the CI by default.