chore: merge 0-8-0-staging into main #1876
Conversation
Summary of ChangesHello @jtobin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request merges the 0-8-0-staging branch into main, introducing several new features and improvements. Key changes include adding pagination and sorting capabilities to the AddrReceives RPC, implementing a BlockHeaderCache to optimize chain interactions by reducing RPC calls, and refactoring macaroon permissions for better security and control. The tests have been updated to cover the new functionalities. My review identifies a bug in a SQL query that could lead to incorrect ordering and a minor redundancy in the RPC server logic. Overall, these are solid improvements to the codebase.
| CASE WHEN sqlc.narg('sort_direction') = 1 THEN addr_events.creation_time END DESC, | ||
| CASE WHEN sqlc.narg('sort_direction') != 1 THEN addr_events.creation_time END ASC |
There was a problem hiding this comment.
The current ORDER BY clause has a subtle bug when sort_direction is NULL. In SQL, NULL != 1 evaluates to NULL, not true. This means if sort_direction is not provided (and becomes NULL), no ordering will be applied, leading to unpredictable results. The default behavior should be ascending order as per the comments.
A more robust way to write this is to handle the NULL case explicitly to default to ascending order.
CASE sqlc.narg('sort_direction')
WHEN 1 THEN addr_events.creation_time
END DESC,
CASE sqlc.narg('sort_direction')
WHEN 1 THEN NULL
ELSE addr_events.creation_time
END ASC|
|
||
| sqlQuery.Offset = req.Offset | ||
| sqlQuery.Limit = req.Limit | ||
| sqlQuery.SortDirection = address.DescSortDirection |
There was a problem hiding this comment.
This line is redundant. The following switch statement correctly handles all cases for setting sqlQuery.SortDirection. The default value for the req.Direction enum is SORT_DIRECTION_DESC, which is handled in the switch.
jtobin
force-pushed
the
0-8-0-staging
branch
from
74a29b2 to
def015a
Compare
Refactor the function by introducing an internal helper to improve readability.
Refactor MacaroonWhitelist to handle public universe proof courier permissions independently. This clarifies the logic and avoids coupling courier access with other universe server permissions.
Remove the defaultMacaroonWhitelist map and inline its entries directly into the conditional logic within MacaroonWhitelist. This ensures that access to previously always-available endpoints is now governed by explicit user configuration (read/write/courier), improving permission control and aligning with expected access restrictions.
Separate the mint anchor transaction fee rate calculation from fundGenesisPsbt into anchorTxFeeRate. This refactor is part of a broader effort to simplify calling fundGenesisPsbt from unit tests.
Extract the wallet funding call into a closure that is passed as an argument. This prepares fundGenesisPsbt to become a standalone function, making it easier to call in unit tests.
Pass the pending batch and chain params into fundGenesisPsbt and convert it into a standalone function rather than a method on ChainPlanter. This change makes it easier to call fundGenesisPsbt from unit tests.
The batch key was only used for logging. This commit moves the log messages outside fundGenesisPsbt, simplifying the function for better code health.
The mock helper FundGenesisTx now returns the index of the change output. It also dynamically computes the index of the change output it adds. These enhancements will be useful when handling packets with supply pre-commitment outputs.
The funding routine now uses the refactored fundGenesisPsbt function, introduced in a previous commit. Which adds test coverage for the batch funding logic. An optional argument is also added to allow skipping funding.
RandSeedlingMintingBatch retires.
Refactored GetBlockTimestamp to call GetBlockHeaderByHeight and return an optional error type. Removed the timestamp-to-block-height cache, as it did not handle re-orgs correctly. This prepares the codebase for a more comprehensive caching mechanism to be added in a follow-up commit.
Introduce a reusable cache that stores full headers keyed by height and hash. Tracks confirmation depth and treats shallow entries as unsettled (return miss). Detects conflicts at a height and invalidates shallower headers on reorg. Size and random purge fraction are configurable (default 100k entries, 10 percent). Not yet used by LndRpcChainBridge.
Adds a block header cache to LndRpcChainBridge, which indirectly improves performance of methods like GetBlockTimestamp by avoiding repeated block header fetches.
Pull Request Test Coverage Report for Build 19502409622Details
💛 - Coveralls |
ffranr
left a comment
ffranr
left a comment
There was a problem hiding this comment.
This looks fine to me. I don't think any of the commit contents have changed.
18db746
4 participants
Simply rebases 0-8-0-staging onto main, and merges it.