Add version fields to RFQ wire messages #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an enumeration type for the wire message data field version to the `rfqmsg` package. This enum type can be used across all RFQ wire messages.
This commit adds a version field to the wire message data component of the Reject message type.
This commit adds a version field to the wire message data component of the BuyRequest message type.
This commit adds a version field to the wire message data component of the BuyAccept message type.
This commit adds a version field to the wire message data component of the SellRequest message type.
This commit adds a version field to the wire message data component of the SellAccept message type.
Roasbeef
reviewed
May 21, 2024
jharveyb
approved these changes
May 22, 2024
| func WireMsgDataVersionEncoder(w io.Writer, val any, buf *[8]byte) error { | ||
| if version, ok := val.(*WireMsgDataVersion); ok { | ||
| versionUint8 := uint8(*version) | ||
| return tlv.EUint8(w, &versionUint8, buf) |
There was a problem hiding this comment.
nit: why not EUint8T like in asset.VersionEncoder?
return tlv.EUint8T(w, uint8(*version), buf)There was a problem hiding this comment.
It should have been tlv.EUint8T. I'll try to keep that in mind in the future. This PR was merged before I got a chance to modify it.
There was a problem hiding this comment.
Sg, could be in the follow-up PR you mentioned above.
guggero
approved these changes
May 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #908