Reduce RFQ wire message type count #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Jun 4, 2024
Adding this method ensures that `WireMsgDataVersion` satisfies the record producer interface.
This commit introduces the `requestWireMsgData` type, encapsulating the fields present in a quote request wire message data field.
This commit refactors the `ToWire` methods for `BuyRequest` and `SellRequest` types to utilize the new `requestWireMsgData` type. This change unifies the wire message type integer for both buy and sell requests.
Having introduced the type `requestWireMsgData`, the inner type `buyRequestMsgData` is now unnecessary.
Having introduced the type `sellRequestMsgData`, the inner type `sellRequestMsgData` is now unnecessary.
guggero
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #914
This PR includes request message changes. It does not include accept message changes, however, should be ready for review and merge as is.