-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public key-based routing #4758
base: master
Are you sure you want to change the base?
Public key-based routing #4758
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -403,8 +403,9 @@ func addHopHint(hopHints *[]func(*zpay32.Invoice), | |
channel *channeldb.OpenChannel, chanPolicy *channeldb.ChannelEdgePolicy) { | ||
|
||
hopHint := zpay32.HopHint{ | ||
NodeID: channel.IdentityPub, | ||
ChannelID: channel.ShortChanID().ToUint64(), | ||
NodeID: channel.IdentityPub, | ||
// Zeroed out for privacy reasons. | ||
// ChannelID: channel.ShortChanID().ToUint64(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Assume in final form, we'd also need to actually extend the invoices themselves to signal to the sender that they need to be able to support pubkey routing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that is currently signaled implicitly by one or more zero channel ids in the route hints. It would also be nice to reduce the invoice size (and qr codes) by removing the eight zero bytes completely. |
||
FeeBaseMSat: uint32(chanPolicy.FeeBaseMSat), | ||
FeeProportionalMillionths: uint32( | ||
chanPolicy.FeeProportionalMillionths, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EZ 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The system is ready and waiting for this feature 😎