server: stagger connReqs to multi-address peers #5925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
changed the title
ellemouton
force-pushed
the
staggerConnToMultipleAddresses
branch
from
b78dd4c to
a73f599
Compare
Roasbeef
requested changes
Nov 3, 2021
Delete all the stored addresses from the persistentPeerAddr map when we prune the persistent peer.
Let the connectToPersistentPeer func handle all connection attempts to persistent peers so that that logic is in once place.
|
Thanks for the review @Roasbeef 🚀 see my comment above re this stagger vs the existing stagger connection config/flag (tldr: existing stagger is for connection between multiple different peers and this stagger is for trying multiple addresses for the same peer so slightly different behaviour is wanted imo) |
In this commit, we stagger the connection attempts to the multiple addresses of a peer.
ellemouton
force-pushed
the
staggerConnToMultipleAddresses
branch
from
a73f599 to
ac4fe5f
Compare
Roasbeef
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a peer has multiple working addresses (like 1 clearnet & 1 tor) we will, on startup and during reconnection, attempt to connect to all their advertised addresses at once. The peer will then accept the first connection and so we will cancel the second one but it already reaches the peer and so then they close the first connection in favour of the second one.
I have tested that this would also happen pre #5538 when
establishPersistentConnectionswould kickoff all the connReqs at once but it would then recover sincepeerTerminationWatcherwould only try to connect to a single address. With #5538,peerTerminationWatcheralso uses all the advertised addresses during it's reconnection attempt and so the issue just keeps repeating itself.In this PR: if we have multiple addresses stored for a peer, we stagger the creation of the connReqs for those addrs.
Fixes #5887