LCORE-1216: Bump up to llama-stack 0.4.3#52
LCORE-1216: Bump up to llama-stack 0.4.3#52are-ces wants to merge 2 commits intolightspeed-core:mainfrom
Conversation
b2b25c6 to
c84a80e
Compare
tisnik
left a comment
There was a problem hiding this comment.
I'd say LGTM on my side. But definitely need at least one more reviewer, especially from teams that managed to use provider(s).
There was a problem hiding this comment.
You are removing the inline::lightspeed_inline_agent we are using in Ansible Lightspeed chatbot, if this PR is merged this will break the chatbot functionality.
There was a problem hiding this comment.
inline::lightspeed_inline_agent still works, the logic has been moved from agent_instance.py to agents.py
lightspeed_stack_providers/providers/remote/agents/lightspeed_agent/lightspeed.py
Outdated
Show resolved
Hide resolved
218e6d4 to
3ad6905
Compare
|
@are-ces @ldjebran I could run the updated
The setup is somehow complicated because it's using a number of codes that are not merged to main yet. I will create a memo on my test setup. Note: My setup does not enable MCP server yet. After writing the memo, I plan to test this with MCP server enabled. |
3ad6905 to
f99d3c1
Compare
|
@are-ces seems the file https://github.com/lightspeed-core/lightspeed-providers/blob/main/resources/external_providers/inline/agents/lightspeed_inline_agent.yaml needs to be updated to: config_class: lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent.config.LightspeedAgentsImplConfig
module: lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent
api_dependencies: [ inference, safety, tool_runtime, tool_groups, conversations, prompts ]
optional_api_dependencies: [vector_io, files]The agent lightspeed_inline_agent is passing through the queries and overriding the temperature when configured , unfortunately I was not able to test mcp filtring as seems the lightspeed-stack has a regression as not passing mcp headers received from client by MCP-HEADERS header. There is a big work done her, @are-ces many thanks for your efforts, |
There was a problem hiding this comment.
@are-ces many thanks for the work the changes that I proposed in my last comment still valid, tested the mcp but seems the lightspeed_inline_agent is unfortunately not working as expected and breaking when enabling the mcp configuration, I see the mcp returning the list of tools, but the agent seems do not detect that tools and see only 2 instead of more than 300.
this will needs more investigations.
84d4bf7 to
622151e
Compare
|
Hey @ldjebran good catch! I have encountered the same problem, I was handling the tools in a wrong way; basically the MCP servers were not being expanded to their tools so we were counting the MCP servers and comparing them with min_tools. |
1daeb16 to
88bb4db
Compare
|
@are-ces Thanks for the updates. I am trying to verify this PR with lightspeed-core/lightspeed-stack#1179 on my CRC instance. I think I can set up the environment today to run the tests. |
5070e07 to
7e235c2
Compare
46c2ab8 to
0f82e43
Compare
TamiTakamiya
left a comment
There was a problem hiding this comment.
@are-ces Sorry for letting you wait so long. Though I am still unable to set up my test environment on my CRC, I could successfully test this PR using a test script + newly built ansible-chatbot-stack container image:
INFO 2026-02-26 04:06:00,253 lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent.agents:302
agents: Previously called tools: set()
INFO 2026-02-26 04:06:00,254 lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent.agents:158
agents: Always included tools (config + previously called): {'knowledge_search'}
INFO 2026-02-26 04:06:00,911 lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent.agents:354
agents: Extracted 127 unique tool definitions from 2 tool configs
INFO 2026-02-26 04:06:00,912 lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent.agents:179
agents: Tool filtering enabled - filtering 127 tools (threshold: 10)
INFO 2026-02-26 04:06:02,009 lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent.agents:237
agents: Filtered tool names from LLM: ['job_templates_list']
I approve this PR. Thank you!
ee9fa8f to
c01e069
Compare
c01e069 to
19137c1
Compare
Description
This is a significant refactoring of all the modules, mostly because the Agents API has been deprecated in favor of the Responses API in llama-stack (already from 0.3.x).
This upgrade is needed to keep
lightspeed-providerson par with LCORENOTE:
run_moderationhas not been designed for redaction but to only block the request, thus lightspeed-redactions will block the message if an unauthorized string is detected, as opposed torun_shieldwhere it is possible to redact the original message.Changes:
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
I tested manually via curl requests the following:
run_shield(valid/invalid questions)run_moderationrun_shield(sensitive data redacted)run_moderation(message with sensitive data BLOCKED)