LCORE-1332: update OpenAPI schema and configuration documentation#1158
Conversation
WalkthroughThis PR introduces Solr vector search configuration support by adding a new SolrConfiguration schema with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/openapi.json (1)
7922-7951:⚠️ Potential issue | 🟡 MinorDocument the new
solrfield in the QueryRequest description.The schema adds
solr, but the attribute list in the description text doesn’t mention it, which makes the generated docs incomplete.✍️ Suggested doc update
- vector_store_ids: The optional list of specific vector store IDs to query for RAG. + vector_store_ids: The optional list of specific vector store IDs to query for RAG. + solr: Optional Solr query parameters (for example, filter queries).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/openapi.json` around lines 7922 - 7951, The QueryRequest description text is missing the newly added solr field; update the QueryRequest documentation block to include an entry for "solr" describing that it is an optional Solr-specific parameter (object or null) containing Solr query parameters such as filter queries (e.g., fq list), its purpose (to pass Solr-specific query options), and that it is optional in the request; ensure the attribute list alongside query, conversation_id, provider, etc., mentions solr and optionally include the example shown in the schema to keep generated docs consistent with the Solr examples.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/config.puml`:
- Around line 74-75: The UML diagram is missing the composition link for the new
solr field; add a composition relationship from Configuration to
SolrConfiguration (e.g., Configuration *-- SolrConfiguration) similar to the
existing SplunkConfiguration link so the diagram reflects the solr :
Optional[SolrConfiguration] attribute; ensure the link uses the same composition
style used for other config blocks (like SplunkConfiguration) and place it
alongside the existing relationships.
---
Outside diff comments:
In `@docs/openapi.json`:
- Around line 7922-7951: The QueryRequest description text is missing the newly
added solr field; update the QueryRequest documentation block to include an
entry for "solr" describing that it is an optional Solr-specific parameter
(object or null) containing Solr query parameters such as filter queries (e.g.,
fq list), its purpose (to pass Solr-specific query options), and that it is
optional in the request; ensure the attribute list alongside query,
conversation_id, provider, etc., mentions solr and optionally include the
example shown in the schema to keep generated docs consistent with the Solr
examples.
| solr : Optional[SolrConfiguration] | ||
| splunk : Optional[SplunkConfiguration] |
There was a problem hiding this comment.
Add the SolrConfiguration composition link to the diagram.
Configuration now exposes solr, but the relationship list doesn’t show the composition link, so the diagram is incomplete compared to other config blocks.
🔧 Proposed UML addition
+src.models.config.SolrConfiguration --* src.models.config.Configuration : solr🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/config.puml` around lines 74 - 75, The UML diagram is missing the
composition link for the new solr field; add a composition relationship from
Configuration to SolrConfiguration (e.g., Configuration *-- SolrConfiguration)
similar to the existing SplunkConfiguration link so the diagram reflects the
solr : Optional[SolrConfiguration] attribute; ensure the link uses the same
composition style used for other config blocks (like SplunkConfiguration) and
place it alongside the existing relationships.
Description
LCORE-1332: update OpenAPI schema and configuration documentation
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit
New Features
Documentation