Skip to content

LCORE-1328 Replace Optional[] with X | None, update test mocks #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 1 commit into from
Feb 24, 2026
Merged

LCORE-1328 Replace Optional[] with X | None, update test mocks #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ async def prepare_tools(


def _build_provider_data_headers(
tools: Optional[list[dict[str, Any]]],
) -> Optional[dict[str, str]]:
tools: list[dict[str, Any]] | None,
) -> dict[str, str] | None:
"""Build extra HTTP headers containing MCP provider data for Llama Stack.

Extracts per-server auth headers from MCP tool definitions and encodes
Expand Down
18 changes: 6 additions & 12 deletions tests/unit/utils/test_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,12 +983,9 @@ async def test_prepare_responses_params_includes_mcp_provider_data_headers(
},
]

mocker.patch("utils.responses.configuration", mocker.Mock())
mocker.patch(
"utils.responses.select_model_and_provider_id",
return_value=("provider1/model1", "model1", "provider1"),
)
mocker.patch("utils.responses.evaluate_model_hints", return_value=(None, None))
mock_config = mocker.Mock()
mock_config.inference = None
mocker.patch("utils.responses.configuration", mock_config)
mocker.patch("utils.responses.get_system_prompt", return_value="System prompt")
mocker.patch(
"utils.responses.prepare_tools", return_value=mcp_tools_with_headers
Expand Down Expand Up @@ -1034,12 +1031,9 @@ async def test_prepare_responses_params_no_extra_headers_without_mcp_tools(

query_request = QueryRequest(query="test") # pyright: ignore[reportCallIssue]

mocker.patch("utils.responses.configuration", mocker.Mock())
mocker.patch(
"utils.responses.select_model_and_provider_id",
return_value=("provider1/model1", "model1", "provider1"),
)
mocker.patch("utils.responses.evaluate_model_hints", return_value=(None, None))
mock_config = mocker.Mock()
mock_config.inference = None
mocker.patch("utils.responses.configuration", mock_config)
mocker.patch("utils.responses.get_system_prompt", return_value="System prompt")
mocker.patch("utils.responses.prepare_tools", return_value=None)
mocker.patch("utils.responses.prepare_input", return_value="test")
Expand Down
Loading