LCORE-1326: Updated Konflux references#1272
Merged
tisnik merged 1 commit intolightspeed-core:mainfrom Mar 5, 2026
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated dependency lock files and CI prefetch configs: numerous dependency versions and their hashes were updated or added in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
requirements-build.txt (1)
57-63:⚠️ Potential issue | 🟠 MajorResolve conflicting duplicate pins in requirements-build.txt.
This file contains unsatisfiable dependency constraints:
hatchling: pinned to both 1.26.3 (line 57) and 1.29.0 (line 62)setuptools: pinned to both 81.0.0 (line 215) and 82.0.0 (line 217)The file is consumed as
requirements_build_filesin Tekton workflows, so these conflicts will break dependency resolution during prefetch.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@requirements-build.txt` around lines 57 - 63, requirements-build.txt contains duplicate conflicting pins for the same packages (hatchling and setuptools); choose and keep a single version for each package across the file (e.g., consolidate hatchling to one pin—prefer the higher compatible version 1.29.0—and consolidate setuptools to a single pin such as 82.0.0), remove the duplicate entries so only one line pins hatchling and one line pins setuptools, update any accompanying comments/markers that referenced the removed pins, and re-run your dependency lock/prefetch step (or regenerate the requirements file) to ensure the Tekton `requirements_build_files` consumer sees a consistent, non-conflicting set of pins.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@requirements-build.txt`:
- Around line 57-63: requirements-build.txt contains duplicate conflicting pins
for the same packages (hatchling and setuptools); choose and keep a single
version for each package across the file (e.g., consolidate hatchling to one
pin—prefer the higher compatible version 1.29.0—and consolidate setuptools to a
single pin such as 82.0.0), remove the duplicate entries so only one line pins
hatchling and one line pins setuptools, update any accompanying comments/markers
that referenced the removed pins, and re-run your dependency lock/prefetch step
(or regenerate the requirements file) to ensure the Tekton
`requirements_build_files` consumer sees a consistent, non-conflicting set of
pins.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1bd8afec-ef84-4860-be12-be8a87775bfd
📒 Files selected for processing (5)
.tekton/lightspeed-stack-pull-request.yaml.tekton/lightspeed-stack-push.yamlrequirements-build.txtrequirements.hashes.source.txtrequirements.hashes.wheel.txt
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 25: The project runtime deps are incomplete: add the missing packages
fastapi, starlette, llama_stack_client, and uvicorn to pyproject.toml
dependencies (in addition to the existing cffi==2.0.0) so imports in
src/app/main.py and src/runners/uvicorn.py resolve at runtime, then regenerate
or update the lock (uv.lock) to include these packages; ensure versions are
compatible with your code (or use caret/latest pinned versions) and run the
lock/update command your toolchain uses to produce an updated uv.lock.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a35fa8d0-5223-4b10-9637-368e77cb8172
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
.tekton/lightspeed-stack-pull-request.yaml.tekton/lightspeed-stack-push.yamlpyproject.tomlrequirements-build.txtrequirements.hashes.source.txtrequirements.hashes.wheel.txtrequirements.overrides.txt
💤 Files with no reviewable changes (3)
- requirements.hashes.wheel.txt
- requirements.overrides.txt
- requirements.hashes.source.txt
🚧 Files skipped from review as they are similar to previous changes (1)
- .tekton/lightspeed-stack-pull-request.yaml
pyproject.toml
Outdated
| "pyasn1>=0.6.2", | ||
| # Used for system prompt template variable rendering | ||
| "jinja2>=3.1.0", | ||
| "cffi==2.0.0", |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import pathlib, re, tomllib
pyproject = tomllib.loads(pathlib.Path("pyproject.toml").read_text())
declared = {
re.split(r'[<>=!~\[]', dep, 1)[0].strip().lower().replace("_", "-")
for dep in pyproject.get("project", {}).get("dependencies", [])
}
lock_text = pathlib.Path("uv.lock").read_text() if pathlib.Path("uv.lock").exists() else ""
locked = set(re.findall(r'(?m)^name = "([^"]+)"', lock_text))
checks = {
"fastapi": "fastapi",
"starlette": "starlette",
"llama_stack_client": "llama-stack-client",
"uvicorn": "uvicorn",
}
files = ["src/app/main.py", "src/runners/uvicorn.py"]
missing = []
for f in files:
p = pathlib.Path(f)
if not p.exists():
continue
txt = p.read_text()
for module, pkg in checks.items():
if re.search(rf'(?m)^(from|import)\s+{re.escape(module)}\b', txt):
if pkg not in declared and pkg not in locked:
missing.append((f, module, pkg))
print("Declared deps:", sorted(declared))
print("Locked packages:", sorted(locked))
if missing:
print("\nMissing runtime packages (not declared and not locked):")
for f, module, pkg in missing:
print(f"- {f}: imports '{module}' but '{pkg}' is absent")
raise SystemExit(1)
print("\nOK: runtime imports are covered by declared dependencies or uv.lock.")
PYRepository: lightspeed-core/lightspeed-stack
Length of output: 492
Restore runtime dependencies required by application entrypoints.
Line 25 declares only cffi, but runtime code imports fastapi, starlette, llama_stack_client, and uvicorn (src/app/main.py, src/runners/uvicorn.py). These packages are absent from both pyproject.toml dependencies and uv.lock, causing import/startup failures outside hermetic prefetch flows.
Proposed direction
dependencies = [
"cffi==2.0.0",
+ # restore direct runtime deps used by entrypoints
+ "fastapi",
+ "starlette",
+ "uvicorn",
+ "llama-stack-client",
]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "cffi==2.0.0", | |
| dependencies = [ | |
| "cffi==2.0.0", | |
| # restore direct runtime deps used by entrypoints | |
| "fastapi", | |
| "starlette", | |
| "uvicorn", | |
| "llama-stack-client", | |
| ] |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pyproject.toml` at line 25, The project runtime deps are incomplete: add the
missing packages fastapi, starlette, llama_stack_client, and uvicorn to
pyproject.toml dependencies (in addition to the existing cffi==2.0.0) so imports
in src/app/main.py and src/runners/uvicorn.py resolve at runtime, then
regenerate or update the lock (uv.lock) to include these packages; ensure
versions are compatible with your code (or use caret/latest pinned versions) and
run the lock/update command your toolchain uses to produce an updated uv.lock.
tisnik
force-pushed
the
lcore-1326-updated-konflux-references
branch
4 times, most recently
from
869ed1d to
0a99fc5
Compare
Contributor
Author
|
/retest |
tisnik
force-pushed
the
lcore-1326-updated-konflux-references
branch
3 times, most recently
from
7d59816 to
09bba2a
Compare
Contributor
Author
|
/retest |
tisnik
force-pushed
the
lcore-1326-updated-konflux-references
branch
4 times, most recently
from
ac74ab0 to
b264db4
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@requirements.hashes.source.txt`:
- Around line 805-810: The requirements pin violates FastAPI's Starlette upper
bound: replace the conflicting starlette==0.52.1 (or update the FastAPI pin) so
fastapi==0.128.1's requirement starlette<0.51.0 is satisfied; specifically
either downgrade starlette to a 0.50.x (e.g., starlette==0.50.*) or upgrade
fastapi (the fastapi package pin) to a version that declares compatibility with
starlette 0.52.x, then run dependency resolution/lock regeneration to ensure all
hashes and transitive deps (starlette, fastapi, sse-starlette, uvicorn,
websockets) are consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ffe5078a-d330-4f71-9c55-81482ae92e9c
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
requirements.hashes.source.txtrequirements.hashes.wheel.txt
💤 Files with no reviewable changes (1)
- requirements.hashes.wheel.txt
tisnik
force-pushed
the
lcore-1326-updated-konflux-references
branch
4 times, most recently
from
fe926ec to
773f6f2
Compare
tisnik
force-pushed
the
lcore-1326-updated-konflux-references
branch
from
773f6f2 to
8c6c670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LCORE-1326: Updated Konflux references
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit