LCORE-1285: Update Llama Stack to 0.5.2#1293
Conversation
…ent, and llama-stack-api; add new package 'circuitbreaker' version 2.1.3 and 'oci' version 2.168.0; adjust supported Llama Stack version in constants; fix response handling in utils.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdates llama-stack packages and related version constant to 0.5.2, adds/updates multiple build and requirements entries (including hashes), and makes defensive attribute access changes in response parsing; test expectation updated to match the new llama-stack version. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/utils/responses.py (1)
1142-1151: Log skipped content parts on the fallback path.This avoids the crash, but it also makes unsupported parts disappear silently. A small debug log here would make empty extracted text much easier to diagnose.
💡 Suggested change
for part in content: part_type = getattr(part, "type", None) if part_type == "input_text": input_text_part = cast(InputTextPart, part) if input_text_part.text: text_fragments.append(input_text_part.text.strip()) elif part_type == "output_text": output_text_part = cast(OutputTextPart, part) if output_text_part.text: text_fragments.append(output_text_part.text.strip()) elif part_type == "refusal": refusal_part = cast(ContentPartRefusal, part) if refusal_part.refusal: text_fragments.append(refusal_part.refusal.strip()) + else: + logger.debug("Skipping unsupported response content part: %r", part)As per coding guidelines, "Use
logger.debug()for detailed diagnostic information".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/utils/responses.py` around lines 1142 - 1151, The fallback path that skips unsupported content parts currently silently drops them; update the logic around the part_type checks (look for the variables part_type, part, and the text_fragments list in the function handling response parts) to call logger.debug() when encountering non-text/unsupported part types (e.g., in the final elif/else branch where "refusal" or other types are handled) so the debug log includes the part_type and a small representation of the part (or its id) to aid diagnosis; ensure you use the module's existing logger (or import one if missing) and keep the message concise and diagnostic.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/utils/responses.py`:
- Around line 1142-1151: The fallback path that skips unsupported content parts
currently silently drops them; update the logic around the part_type checks
(look for the variables part_type, part, and the text_fragments list in the
function handling response parts) to call logger.debug() when encountering
non-text/unsupported part types (e.g., in the final elif/else branch where
"refusal" or other types are handled) so the debug log includes the part_type
and a small representation of the part (or its id) to aid diagnosis; ensure you
use the module's existing logger (or import one if missing) and keep the message
concise and diagnostic.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d703aad5-1415-4222-9323-04cdd2ee2b0c
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
pyproject.tomlsrc/constants.pysrc/utils/responses.pytests/e2e/features/info.feature
tisnik
left a comment
There was a problem hiding this comment.
Please try to update Konfux references as well. This way we'll see if/how it builds in Konflux
@tisnik By this do you mean running |
Description
Updated Llama Stack to 0.5.X in order to enable the network configuration on providers so that TLS and Proxy support can be added.
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit
Chores
Bug Fixes
Tests