Skip to content

LCORE-1449: Use proper type specification #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 2 commits into from
Mar 11, 2026
Merged

LCORE-1449: Use proper type specification #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00913a4
LCORE-1449: Use proper type specification in LCORE sources
tisnik Mar 11, 2026
b86cf64
Check can be done on CI
tisnik Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ disable = ["R0801"]
extend-exclude = ["tests/profiles/syntax_error.py"]

[tool.ruff.lint]
extend-select = ["TID251", "UP006", "UP007", "UP017", "UP035", "RUF100", "B009", "B010"]
extend-select = ["TID251", "UP006", "UP007", "UP010", "UP017", "UP035", "RUF100", "B009", "B010"]

[tool.ruff.lint.flake8-tidy-imports.banned-api]
unittest = { msg = "use pytest instead of unittest" }
Expand Down
8 changes: 4 additions & 4 deletions src/utils/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Common types for the project."""

from typing import Annotated, Any, Literal, Optional, TypeAlias
from typing import Annotated, Any, Literal, Optional

from llama_stack_api import ImageContentItem, TextContentItem
from llama_stack_api.openai_responses import (
Expand Down Expand Up @@ -131,7 +131,7 @@ class ShieldModerationBlocked(BaseModel):
Field(discriminator="decision"),
]

IncludeParameter: TypeAlias = Literal[
type IncludeParameter = Literal[
"web_search_call.action.sources",
"code_interpreter_call.outputs",
"computer_call_output.output.image_url",
Expand All @@ -141,7 +141,7 @@ class ShieldModerationBlocked(BaseModel):
"reasoning.encrypted_content",
]

ResponseItem: TypeAlias = (
type ResponseItem = (
ResponseMessage
| WebSearchToolCall
| FileSearchToolCall
Expand All @@ -153,7 +153,7 @@ class ShieldModerationBlocked(BaseModel):
| McpApprovalResponse
)

ResponseInput: TypeAlias = str | list[ResponseItem]
type ResponseInput = str | list[ResponseItem]


class ResponsesApiParams(BaseModel):
Expand Down
Loading