LSPAY-33449: React18 typings #190
Conversation
ls-urs-keller
force-pushed
the
LSPAY-33449
branch
15 times, most recently
from
2312531 to
e723c51
Compare
- Typings, - Updating gh actions, depracated actions/cache@v1 - Allow prerelease on branch LSPAY-33449
ls-urs-keller
force-pushed
the
LSPAY-33449
branch
11 times, most recently
from
b9d67ce to
8f2da7f
Compare
ls-urs-keller
force-pushed
the
LSPAY-33449
branch
from
1669c81 to
0d8b904
Compare
- @lightspeed/[email protected] - @lightspeed/[email protected]
nwallace534
left a comment
nwallace534
left a comment
There was a problem hiding this comment.
Understand this has been in use already. I skim reviewed and added a few questions but no blockers found and all code has been glanced at.
Sure glad I don't use snapshot testing anymore, it doesn't add anything but lines to review in PRs.
| // TODO: use prettier.resolveConfigFile instead... | ||
| prettierConfig.parser = 'babel'; | ||
|
|
||
| // Function to sanitize SVG attributes for JSX compatibility |
There was a problem hiding this comment.
Discussed via slack. AI generated script to fill in for lib no longer compatible.
| import * as React from 'react'; | ||
| import { storiesOf } from '@storybook/react'; | ||
| import { withReadme } from 'storybook-readme'; | ||
| import Readme from './README.md'; |
There was a problem hiding this comment.
Is this local README.md still in the repo or referenced elsewhere? If not I'd recommend removing
| import { Tooltip, TooltipPlacement } from './Tooltip'; | ||
| import { Input } from '../Input'; | ||
| import { ExampleBox } from '../../../../.storybook/components/ExampleBox'; | ||
| import Readme from './README.md'; |
There was a problem hiding this comment.
Mentioned elsewhere, does this README still get uesd?
| "@styled-system/theme-get": "5.0.16", | ||
| "styled-system": "^5.0.16" | ||
| }, | ||
| "peerDependencies": { |
There was a problem hiding this comment.
Not a comment on your PR but I do wonder why there is a handlebars file with a package.json like what could it possibly be adding to a project.
| "command": { | ||
| "publish": { | ||
| "allowBranch": ["master", "next"], | ||
| "allowBranch": ["master", "next", "LSPAY-33449"], |
There was a problem hiding this comment.
will this hardcoded branch be removed soon?
| "prop-types": "^15.6.0", | ||
| "react": "^16.8.6", | ||
| "react-dom": "^16.8.6", | ||
| "react": "^18.3.1", |
JIRA Ticket: LSPAY-33449
Description
Adding React18 typings
How to test?
yarn devChecklist