Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add istio collector k8s example #51

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

heydbut
Copy link
Contributor

@heydbut heydbut commented Sep 21, 2023

Description

What does this PR do?
feat: add istio collector k8s example

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.

@heydbut heydbut self-assigned this Sep 21, 2023
@heydbut heydbut force-pushed the feat/collector/istio branch 2 times, most recently from e673658 to 9b051cb Compare September 21, 2023 18:54
@heydbut heydbut marked this pull request as ready for review September 21, 2023 20:16
@heydbut heydbut changed the title feat: add istio collector k8s example Add istio collector k8s example Oct 6, 2023
@nslaughter nslaughter marked this pull request as draft October 11, 2023 16:18
@nslaughter
Copy link
Collaborator

Converting to draft until it works as expected.

@heydbut heydbut marked this pull request as ready for review October 16, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants