Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidb dashboard #60

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Add tidb dashboard #60

merged 1 commit into from
Oct 13, 2023

Conversation

heydbut
Copy link
Contributor

@heydbut heydbut commented Oct 6, 2023

Description

What does this PR do?
Add tidb dashboard #60

Requires #58

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.

@heydbut heydbut self-assigned this Oct 6, 2023
@heydbut
Copy link
Contributor Author

heydbut commented Oct 6, 2023

app lightstep com_dev_bcronin_dashboard_tidb-overview_DSlBkYwW_time_window=hours_4

Copy link
Collaborator

@nslaughter nslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful dashboard that covers an important service. Thank you!

@nslaughter nslaughter merged commit c364ef2 into main Oct 13, 2023
3 checks passed
@nslaughter nslaughter deleted the feat/collector/tidb-dashboard branch October 13, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants