Podman compatibility

[christianberg]

Use docker version instead of docker when checking if Docker is installed. When docker is used as an alias for podman, the original script fails, because podman without any subcommand exits with code 125.

Many companies are moving towards podman as a drop-in replacement for docker for local development, because of licensing issues with Docker Desktop.

[yasirmturk]

👍

[fogfish]

Should we use environment variable instead of docker command? and/or fallback into docker if the variable is not defined ?

[christianberg]

In my opinion, being able to set the docker command name via an env variable would be a nice-to-have, but not strictly necessary. I believe most users who adopt podman as a drop-in replacement for docker create an alias or symlink, so that scripts using docker generally still work.

[fogfish]

The usage of alias is a good practice in the beginning of the adoption journey but we know the reality. The following claim alias docker=podman is not always holds true. In the worst case, you as developer of the solution just test things on the docker and assume it would automatically work on the podman. My comment about environment variables was not really to help life easier for users of this solutions but rather for maintainers of lightstep-developer-satellite. Maintainers should not forget about other environments than docker one. Environment variable should raise the attention for other config options and help on testing it.

[oporkka]

This is very close to the fix I made to lighstep developer satellite script on my local machine 👍

IMO this would be useful to merge

[fogfish]

👍

[fogfish]

Just curios... Is this repository actively maintained by lightstep