Skip to content

Commit

Permalink
LS-5330: Make TLS the default collector_encryption
Browse files Browse the repository at this point in the history
This was the default before my proto change. And I noticed this
open PR #43
which had some feedback about that.
  • Loading branch information
frenchfrywpepper committed Sep 5, 2018
1 parent b3a2b33 commit bbc90d5
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
10 changes: 5 additions & 5 deletions examples/http/context_in_headers.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,16 @@ def lightstep_tracer_from_args():
default='collector.lightstep.com')
parser.add_argument('--port', help='The LightStep reporting service port.',
type=int, default=443)
parser.add_argument('--use_tls', help='Use TLS for reporting',
dest="use_tls", action='store_true')
parser.add_argument('--no_tls', help='Disable TLS for reporting',
dest="no_tls", action='store_true')
parser.add_argument('--component_name', help='The LightStep component name',
default='TrivialExample')
args = parser.parse_args()

if args.use_tls:
collector_encryption = 'tls'
else:
if args.no_tls:
collector_encryption = 'none'
else:
collector_encryption = 'tls'

return lightstep.Tracer(
component_name=args.component_name,
Expand Down
10 changes: 5 additions & 5 deletions examples/nontrivial/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,16 @@ def lightstep_tracer_from_args():
default='collector.lightstep.com')
parser.add_argument('--port', help='The LightStep reporting service port.',
type=int, default=443)
parser.add_argument('--use_tls', help='Use TLS for reporting',
dest="use_tls", action='store_true')
parser.add_argument('--no_tls', help='Disable TLS for reporting',
dest="no_tls", action='store_true')
parser.add_argument('--component_name', help='The LightStep component name',
default='NonTrivialExample')
args = parser.parse_args()

if args.use_tls:
collector_encryption = 'tls'
else:
if args.no_tls:
collector_encryption = 'none'
else:
collector_encryption = 'tls'

return lightstep.Tracer(
component_name=args.component_name,
Expand Down
10 changes: 5 additions & 5 deletions examples/trivial/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,18 @@ def lightstep_tracer_from_args():
default='collector.lightstep.com')
parser.add_argument('--port', help='The LightStep reporting service port.',
type=int, default=443)
parser.add_argument('--use_tls', help='Use TLS for reporting',
dest="use_tls", action='store_true')
parser.add_argument('--no_tls', help='Disable TLS for reporting',
dest="no_tls", action='store_true')
parser.add_argument('--component_name', help='The LightStep component name',
default='TrivialExample')
parser.add_argument('--use_http', help='Use proto over http',
dest="use_http", action='store_true')
args = parser.parse_args()

if args.use_tls:
collector_encryption = 'tls'
else:
if args.no_tls:
collector_encryption = 'none'
else:
collector_encryption = 'tls'

return lightstep.Tracer(
component_name=args.component_name,
Expand Down

0 comments on commit bbc90d5

Please sign in to comment.