Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TBinaryProtocolAccelerated when serializing reports. #90

Closed

Commits on Jan 14, 2020

  1. Use TBinaryProtocolAccelerated when serializing reports.

    We're currently seeing our services spend a large amount of time inside of the lightstep sdk
    serializing reports when they instrument themselves with tracing.  This is in large part due to
    the fact that lightstep is using the pure python implemenation of Thrift.
    
    Fixes lightstep#89
    Roy Williams committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    d843781 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Removing status code check

    When using THttpClient.THttpClient as the transport, an invalid status code could cause memory usage to spike. This behaviour is corrected via TTransport.TBufferedTransport, so this check is no longer needed.
    
    Signed-off-by: Alex Boten <[email protected]>
    Alex Boten committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    0f3a3e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2020

  1. Merge remote-tracking branch 'upstream/master' into use_accelerated_t…

    …hrift_protocol
    Alex Boten committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    59b50ba View commit details
    Browse the repository at this point in the history
  2. Remove check again, lost in merge

    Signed-off-by: Alex Boten <[email protected]>
    Alex Boten committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    019bca4 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Merge remote-tracking branch 'upstream/master' into use_accelerated_t…

    …hrift_protocol
    Alex Boten committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    4f2215d View commit details
    Browse the repository at this point in the history