Add support for datasource query template variables #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterSquishy
approved these changes
Aug 19, 2024
Comment on lines
91
to
92
| 'attribute-types': ['keys'], | ||
| 'telemetry-types': ['spans', 'metrics', 'logs'], |
There was a problem hiding this comment.
ooc why not at least scope to oldest-time/youngest-time?
DHedgecock
force-pushed
the
variables-support
branch
from
a919910
to
edfecc0
Compare
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for:
What needed to change in the code and why?
Variables support was configured for the datasource with a custom editor for selecting a variable key.