Add envoy dashboard #95
Conversation
| } | ||
| group { | ||
| rank = 0 | ||
| title = "" |
There was a problem hiding this comment.
The group without a title seems wrong. Oversight? Trying to accomplish some formatting with the empty group?
There was a problem hiding this comment.
We should not remove this. It's the default unamed group for some charts
| query_name = "((1-(a/b))*100)" | ||
| display = "big_number" | ||
| hidden = false | ||
| query_string = "with\n a = metric envoy_cluster_upstream_rq_xx | filter (((envoy_response_code_class == \"5\") || (envoy_response_code_class == 5)) || (envoy_response_code_class == 5.0)) | rate 5m, 5m | group_by [], mean;\n b = metric envoy_cluster_upstream_rq_completed | rate 5m, 5m | group_by [], mean;\njoin (((1-(a / b))*100)), a=0, b=0 | reduce 5m, mean" |
There was a problem hiding this comment.
I find the name confusing. Looks like the metric is 1 - (5XXs / Completed). In this context I find it confusing to call that a Success Rate, because I think of that as 2XXs. Not sure but also seems like we'd group_by the code class, but hard to tell the intent without the context of the whole dashboard.
There was a problem hiding this comment.
It's the new version of envoy. I find it confusing but I translated an existing dashboard and it was like this
| } | ||
|
|
||
| resource "lightstep_dashboard" "otel_collector_envoy_dashboard" { | ||
| project_name = var.cloud_observability_project |
There was a problem hiding this comment.
| project_name = var.cloud_observability_project | |
| project_name = var.lightstep_project |
Description
What does this PR do?
Add lastest envoy dashboard
PR checklist
Please confirm the following items: