Add dnsmasq as an optional container#8
Conversation
chregu
changed the title
Aerzas
left a comment
Aerzas
left a comment
There was a problem hiding this comment.
Thank you for the proposition that's a good idea. I've added a few comment if you mind having a look.
|
|
||
| ADD dnsmasq.conf /etc/ | ||
|
|
||
| EXPOSE 53 53/udp |
There was a problem hiding this comment.
I would probably avoid creating an image with a root user just in case.
| #log all dns queries | ||
| log-queries | ||
| #dont use hosts nameservers | ||
| no-resolv |
There was a problem hiding this comment.
Should we consider no-hosts also ?
| @@ -0,0 +1,51 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Maybe this part should added to pontsun-cli rather than here ?
| @@ -0,0 +1,8 @@ | |||
| FROM alpine:edge | |||
There was a problem hiding this comment.
Ideally this should not be part of this repo but available as a global image on the Liip docker registry.
There was a problem hiding this comment.
where would you put the Dockerfile then?
There was a problem hiding this comment.
Maybe in a dedicated repo so it can be managed in parallel of Pontsun. But this can be later of course.
2 participants
Up for discussion on the details
Not sure, if the
add-host.shis too much for this project, or if this should go to pontsun-cli.