Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paper per review #68

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Update paper per review #68

merged 3 commits into from
Feb 2, 2022

Conversation

lilyminium
Copy link
Owner

Description

Relates to openjournals/joss-reviews#4100 (comment)

Changes made

  • Added a summary section from the background section
  • Split statement of need with Functionality
  • Added potential use cases to Statement of need
  • Removed some citations

Checklist

  • Tagged issue being addressed
  • Tests
  • Documentation
  • Changelog

@lilyminium
Copy link
Owner Author

Hopefully this link is stable -- a rendered preview: https://res.cloudinary.com/hkvhhndao/image/upload/v1643413636/h0eyvqcgv02su9kedi8t.pdf

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #68 (7135b04) into master (c61ac08) will not change coverage.
The diff coverage is n/a.

❗ Current head 7135b04 differs from pull request most recent head eab7430. Consider uploading reports for the commit eab7430 to get more accurate results

@ptmerz
Copy link

ptmerz commented Jan 31, 2022

Looks great, this addresses my comments!

Nit that I noticed while looking at the rendered pdf: There's a missing space on line 54 (pdf) / 56 (source):

`resp` [@bayly1993],written

@lilyminium lilyminium merged commit 2a86571 into master Feb 2, 2022
@lilyminium lilyminium deleted the update-paper branch February 2, 2022 11:51
@lilyminium
Copy link
Owner Author

Thanks for finding that @ptmerz!

lilyminium added a commit that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants