Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run nerdctl with suid in nc #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions edition/min
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export LIMA_INSTALL_IPTABLES=false
export LIMA_INSTALL_LIMA_INIT=false
export LIMA_INSTALL_LOGROTATE=false
export LIMA_INSTALL_NERDCTL=false
export LIMA_INSTALL_NERDCTL_SUID=false
export LIMA_INSTALL_OPENSSH_SFTP_SERVER=false
export LIMA_INSTALL_SSHFS=false
export LIMA_INSTALL_ZSTD=false
1 change: 1 addition & 0 deletions edition/rd
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ LIMA_INSTALL_IPTABLES=true
LIMA_INSTALL_LIMA_INIT=true
LIMA_INSTALL_LOGROTATE=true
LIMA_INSTALL_NERDCTL=true
LIMA_INSTALL_NERDCTL_SUID=true
LIMA_INSTALL_OPENSSH_SFTP_SERVER=true
LIMA_INSTALL_SSHFS=true
LIMA_INSTALL_ZSTD=true
4 changes: 3 additions & 1 deletion genapkovl-lima.sh
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,9 @@ if [ "${LIMA_INSTALL_NERDCTL}" == "true" ]; then
mkdir -p "${tmp}/usr/local/bin/"
for bin in buildctl buildkitd nerdctl; do
cp "${tmp}/nerdctl/bin/${bin}" "${tmp}/usr/local/bin/${bin}"
chmod u+s "${tmp}/usr/local/bin/${bin}"
if [ "${LIMA_INSTALL_NERDCTL_SUID}" == "true" ]; then
chmod u+s "${tmp}/usr/local/bin/${bin}"
fi
done
fi

Expand Down