-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the embedded default user in alpine cloud #2364
Conversation
Can we test this in CI? |
Testing on Linux should be enough, I think that Mac "got away" with it because it uses UID 500 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with deleting the alpine
user; it only exists so you can test the image without setting up a cloud-init profile.
But I think we should make an exception if the local user is also called alpine
. Otherwise we would have to use the lima
user name inside the VM.
Note that I haven't tested if using alpine
as a host username would work otherwise; maybe it would still be broken for other reasons.
I think that cloud-init should handle this anyway, by using the "default_user" and the distro default /etc/could config? So it should probably be made conditional, and not be called for "cloudinit" variant |
There should not be a non-system user in the image. Let cloud-init handle the users and groups instead. Signed-off-by: Anders F Björklund <[email protected]>
ed3217b
to
7b08d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There should not be a non-system user in the image.
Let cloud-init handle the users and groups instead.
Closes #2362
Fixes the boot on Linux, and then you can add nerdctl.
sudo apk add nerdctl containerd buildctl buildkit