-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store time of last modified in cache dir #2368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
force-pushed
the
cache-time
branch
2 times, most recently
from
May 27, 2024 15:33
3fc2e78
to
a582fc1
Compare
AkihiroSuda
reviewed
Jun 1, 2024
AkihiroSuda
reviewed
Jun 1, 2024
Now the user (proxy) will need to use |
afbjorklund
force-pushed
the
cache-time
branch
2 times, most recently
from
June 2, 2024 12:09
ceb657a
to
31916a2
Compare
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Added some unit tests. |
AkihiroSuda
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking more at caching, and thought it would be a good idea to store the last modified time too.
Then you can do things such as If-Modified-Since and helps when looking at implementing a simple proxy.
When caching more things than OS images, it is also useful to record the content type (deb, tar, whatever)
WARN[0000] reference for unknown type: application/octet-stream
The information is available in the
Result
, when retreiving cached files (but the string can be empty)It would be possible to add the content instead, and use empty string for older cache without the files.