-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow compressing lima-guestagent with gzip #2438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like usrlocalsharelima.Open
does not belong in that package because it has nothing to do with that location, but I don't have any other suggestion. Maybe fileutils
?
Anyways, I'm fine with merging as-is.
I can move the code back to pkg/cidata again, now that it is a lot smaller. I wanted the compression to be abstract/local, but it leaked out anyway... |
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
1a7c043
to
fa19eff
Compare
Something like
But I can't find the format detection (file magic) either? i.e. it is also missing from the compress/gzip module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic seems correct, but I would prefer a simplified expression that keeps the error handling close to the location the error occurred.
Signed-off-by: Anders F Björklund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Remove all compression configuration, and make it boolean.
Could become the default config (y), after some evaluation.
Replaces #2427
Closes #2426