Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes content type header validaton #70

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

juanf
Copy link
Contributor

@juanf juanf commented Jun 6, 2024

Hi, I've noticed that in the tests the content-type header wasn't being validated correctly, this fixes it and adds coverage.

@juanf
Copy link
Contributor Author

juanf commented Jun 6, 2024

Oh @arietimmerman I see this fails because it returns 404 error instead of 400
The 400 on src/Middleware/SCIMHeaders.php is ignored:
throw new SCIMException(sprintf('The content-type header should be set to "%s"', 'application/scim+json'), 400);
This PR should fix it #68

@arietimmerman
Copy link
Collaborator

I've now merged in #68, I guess you'll need to rebase this branch to master to fix the failing pipeline?

@juanf
Copy link
Contributor Author

juanf commented Jun 6, 2024

Hi @arietimmerman thank you for your work on this package, it's super helpful.
Now some tests pass but on those failing this is what I get, I'm not sure why

Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line [11](https://github.com/limosa-io/laravel-scim-server/actions/runs/9402556040/job/25896964640?pr=70#step:5:12):
  - Element 'phpunit', attribute 'backupStaticProperties': The attribute 'backupStaticProperties' is not allowed.
  - Element 'phpunit', attribute 'cacheDirectory': The attribute 'cacheDirectory' is not allowed.

@juanf
Copy link
Contributor Author

juanf commented Jun 28, 2024

Hi @arietimmerman the pipeline is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants