Remark command #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remark 1 r/ instead of remark) w/ RemarkCommandParser that helps parse/token string inputs and also update some tests
…of String, and replace all String usages with Remark class instead, and add simple RemarkTest
…allow support) through the implementation Person.java, user will not be able to use the add and edit commands to modify the remarks field, also changed some sample data to include remarks
…nd fix tests to have remarks
…update the tests accordingly
…d to work and connect all the components together and also add new test to test the changes
…ception/ null exception), but seems ok after retrying, so added this.remark back so that values can be shown on UI
…odel); seems to be causing the model and expectedmodel comparison to have errors, so it is removed
limyongsong
added a commit
that referenced
this pull request
Oct 25, 2017
[7.7] Add some user stories, use cases, non functional requirements and glossary to developer guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added remark command by following the guide:
https://nus-cs2103-ay1718s1.github.io/addressbook-level4/DeveloperGuide.html#creating-a-new-command-code-remark-code
se-edu#599
Commits are done by following the steps from se-edu PRs: (with very minor changes)
Logic: Teach the app to accept 'remark' but do nothing …
Logic: Teach the app to accept 'remark' arguments but still do nothing …
Ui: Add a placeholder for remark in PersonCard GUI …
Model: Add Remark class …
Model: Modify
ReadOnlyPersonto support aRemarkfield …Storage: Add Remark field to XmlAdaptedPerson class
Test: Add withRemark() for PersonBuilder
Ui: Connect Remark field to PersonCard …
Logic: Implement RemarkCommand execute() logic
Note: Remarks command could be modified to make a ToDo command instead with some changes