Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-1556 fix eventbus healthcheck fails when start TMail with redis event bus #1566

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

hungphan227
Copy link
Contributor

No description provided.

@hungphan227
Copy link
Contributor Author

Maybe need a test

@hungphan227 hungphan227 force-pushed the ISSUE-1556-Fix-eventbus-healthcheck-fails-when-start-TMail-with-Redis-event-bus branch from 3002bb1 to f1fe17e Compare February 27, 2025 09:09
Copy link
Member

@quantranhong1999 quantranhong1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a healthcheck test in DistributedServerWithRedisEventBusKeysTest - which was unhealthy in the ticket?

@hungphan227 hungphan227 force-pushed the ISSUE-1556-Fix-eventbus-healthcheck-fails-when-start-TMail-with-Redis-event-bus branch from f1fe17e to 13697d9 Compare February 27, 2025 10:49
@Arsnael
Copy link
Member

Arsnael commented Feb 27, 2025

@hungphan227 hungphan227 force-pushed the ISSUE-1556-Fix-eventbus-healthcheck-fails-when-start-TMail-with-Redis-event-bus branch from 13697d9 to 42dacd7 Compare February 28, 2025 02:37
@hungphan227 hungphan227 force-pushed the ISSUE-1556-Fix-eventbus-healthcheck-fails-when-start-TMail-with-Redis-event-bus branch 3 times, most recently from b094a96 to e92449f Compare February 28, 2025 06:41
@hungphan227 hungphan227 force-pushed the ISSUE-1556-Fix-eventbus-healthcheck-fails-when-start-TMail-with-Redis-event-bus branch from e92449f to 226cab3 Compare February 28, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants