Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Some actions are not working when Semantics enabled #3086

Open
wants to merge 39 commits into
base: refactor
Choose a base branch
from
Open

[FIX] Some actions are not working when Semantics enabled #3086

wants to merge 39 commits into from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Aug 14, 2024 •
edited
Loading

Issue related

#2977

Action affected

  1. Advanced Search
  • Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions
  • Overlap suggestion view with advanced search view
  • Advanced search view auto closed when click any field
  • (CHROME) Has attachment check-box still lost focus (click on it, but the view below got the click)
  • Advanced search dialog view cannot be closed when click advanced search icon
  • Select all button is clicked, even advanced search stay overlays
  • Select, Mark as read, Starred button is clicked in item email, even advanced search stay overlays
  • Has Attachment, All time, From button is clicked, even advanced search or suggestion search view stay overlays
  • Open quick search dialog, select in quick chip: From me , Last 7 days or Has attachment, after that we can not input text in quick search
  1. App Grid
  • Cannot click item in app grid
  1. Mailbox Creator
  • Text field not focus when click
  1. Popup Menu
  • Cannot click item
  1. Dropdown Menu
  • Cannot click item
  1. Composer
  • Lost editor focus
  • Lost subject focus
  • Cannot click bottom option (RichText, Send, Draft,...)
  • Focus of body composer is lost after change font family
  • Focus indicator still display, but can not fill text in composer body after change color background
  1. Rename Mailbox
  • Text Field missing focus
  1. Contact view
  • Text field not focus when click
  • Duplicate open Contact View
  1. Sort By
  • Cannot click item
  1. Language
  • Cannot change language
  1. Forward View
  • Input field lost focus when clicked
  1. Vacation View
  • Subject field cannot focus when clicked
  • Can not select time in vacation
  • Can not select text color in vacation form
  • Paragraph dialog & Order list dialog open twice and cannot be closed
  1. Search Mailbox, Email View
  • Text field not focus when click
  • Can not use delete button in keyboard in search bar for folder if user not click on this one more time
  1. Rich Text Toolbar
  • Text color dialog opens twice
  • Paragraph dialog & Order list dialog open twice and cannot be closed
  1. PDF Viewer
  • When I click to open PDF in list, list is closed
  1. Rule Filter
  • Focus is totally lost in quick form of creating email rule

Flutter Issue Related

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3086.

@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from 4d2dcdf to 3f4cfa0 Compare August 15, 2024 08:48
@hoangdat
Copy link
Member

hoangdat commented Aug 19, 2024 •
edited by dab246
Loading

  • Adr for semantic

@hoangdat
Copy link
Member

hoangdat commented Aug 19, 2024 •
edited by dab246
Loading

  • composer: lost focus when click onetime 🔥 🔥 🔥

@dab246 dab246 changed the title [WIP][HOT-FIX] Some actions are not working when Semantics enabled [HOT-FIX] Some actions are not working when Semantics enabled Aug 21, 2024
@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from c15cc6a to 1683f07 Compare August 21, 2024 11:36
@hoangdat hoangdat changed the title [HOT-FIX] Some actions are not working when Semantics enabled [FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@dab246 dab246 changed the title [FIX] Some actions are not working when Semantics enabled [HOT-FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@dab246 dab246 changed the title [HOT-FIX] Some actions are not working when Semantics enabled [FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@tddang-linagora
Copy link
Contributor

Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions

Please check again
Env: preprod
Build mode: profile

Screen.Recording.2024-08-27.at.10.04.37.mov

@tddang-linagora
Copy link
Contributor

tddang-linagora commented Aug 27, 2024 •
edited by dab246
Loading

Composer

Env: preprod
Build mode: profile

  • Text color dialog opens twice
Screen.Recording.2024-08-27.at.10.48.50.mov
  • Paragraph dialog & Order list dialog open twice and cannot be closed
Screen.Recording.2024-08-27.at.10.55.42.mov
Screen.Recording.2024-08-27.at.10.57.22.mov

@dab246
Copy link
Member Author

dab246 commented Aug 29, 2024

  • Advanced Search dialog cannot be closed when click advanced search icon
Screen.Recording.2024-08-29.at.10.53.52.mov

@dab246
Copy link
Member Author

dab246 commented Aug 29, 2024

  • Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions
Screen.Recording.2024-08-29.at.13.50.52.mov

@jay-athelas
Copy link

Will this be reviewed one day ? nearby future maybe?

@hoangdat
Copy link
Member

hoangdat commented Sep 4, 2024

hi @jay-athelas it is still in progress. We need to test the whole app carefully. All the components, widgets need to test. Can you also take a look and helf us on it?

@Xola11
Copy link

Xola11 commented Sep 4, 2024 •
edited
Loading

@hoangdat I have tested the app, do you perhaps have a timeframe when will this fix be released?

@tddang-linagora tddang-linagora mentioned this pull request Sep 20, 2024
Draft
@hoangdat
Copy link
Member

hoangdat commented Sep 23, 2024 •
edited by dab246
Loading

  • select all button is clicked, even advanced search stay overlays
Screen.Recording.2024-09-23.at.11.26.26.mov

@hoangdat
Copy link
Member

hoangdat commented Sep 23, 2024 •
edited
Loading

  • Open quick search dialog, select in quick chip: From me Last 7 days or Has attachment, after that we can not input text in quick search
  1. open quick search
  2. select From me
  3. try to typing in keyboard, text is not filled in quick search
Screen.Recording.2024-09-23.at.11.52.13.mov

@hoangdat
Copy link
Member

hoangdat commented Sep 23, 2024 •
edited by dab246
Loading

  • focus is totally lost in quick form of creating email rule
Screen.Recording.2024-09-23.at.11.56.24.mov

@hoangdat
Copy link
Member

hoangdat commented Sep 23, 2024 •
edited by dab246
Loading

  • focus of body composer is lost after change font family
  • focus indicator still display, but can not fill text in composer body after change color background
  • use tab to change focus but focus is never go to body of composer

@hoangdat
Copy link
Member

hoangdat commented Sep 23, 2024 •
edited by dab246
Loading

  • can not select time in vacation
Screen.Recording.2024-09-23.at.14.28.32.mov

@hoangdat
Copy link
Member

hoangdat commented Sep 23, 2024 •
edited by dab246
Loading

  • can not select text color in vacation form
Screen.Recording.2024-09-23.at.14.43.33.mov

@dab246
Copy link
Member Author

dab246 commented Sep 26, 2024

  • focus is totally lost in quick form of creating email rule

Screen.Recording.2024-09-23.at.11.56.24.mov

Fixed.

demo-rule.mov

@dab246
Copy link
Member Author

dab246 commented Sep 30, 2024

  • can not select text color in vacation form

Screen.Recording.2024-09-23.at.14.43.33.mov

Fixed

Screen.Recording.2024-09-30.at.17.00.50.mov

@dab246
Copy link
Member Author

dab246 commented Sep 30, 2024

  • can not select time in vacation

Screen.Recording.2024-09-23.at.14.28.32.mov

Fixed

Screen.Recording.2024-09-30.at.16.55.44.mov

@dab246
Copy link
Member Author

dab246 commented Sep 30, 2024

  • use tab to change focus but focus is never go to body of composer

Need merged

linagora/html-editor-enhanced#46

Resolved

Screen.Recording.2024-09-30.at.17.10.39.mov

@dab246
Copy link
Member Author

dab246 commented Oct 1, 2024

  • select all button is clicked, even advanced search stay overlays

Screen.Recording.2024-09-23.at.11.26.26.mov

Fixed

select-all-button.mov

@dab246
Copy link
Member Author

dab246 commented Oct 2, 2024 •
edited
Loading

  • focus of body composer is lost after change font family

Focus is not lost, only cursor indicator is lost, we can still enter text. This error is related to the summernote library being used. There is currently no solution to fix it. Follow issue summernote-issues#4697

font-name.mov
  • focus indicator still display, but can not fill text in composer body after change color background

Fixed

back-ground.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat Awaiting requested review from hoangdat

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dab246 @hoangdat @tddang-linagora @jay-athelas @Xola11