Zarr3 #49
Zarr3 #49
Conversation
# Conflicts: # linc_convert/modalities/lsm/spool.py # linc_convert/utils/spool.py # linc_convert/utils/zarr/generate_pyramid.py
# Conflicts: # linc_convert/modalities/lsm/spool.py # linc_convert/modalities/wk/__init__.py # linc_convert/utils/zarr/generate_pyramid.py # pyproject.toml
|
@balbasty I've done the suggested fix. Please take a look and see if there is anything needs attention. I would hold the merge for a moment. I want to include a few more improvement and fixes including nifti header integration. I will post a issue related to that. |
|
Before anything, I thought one of the conclusions of the previous discussion was that it would be useful to have the package works when TS is available, but not ZP. Now you've made the TS driver depend on the ZP driver, which makes this feature impossible to implement. I still think it's a good idea to have both drivers completely independent and be able to pick only one of them as a dependency. |
we still want to use from-scratch approach for group management. hence we can write zarr3 without zarr-python-v3+
I've reverted the changes and added the required feature. Now the tensorstore driver can operate without zarr-python at all. |
|
Fantastic @calvinchai ! Great effort Do we need a few new tests? Like maybe writing a sharded zarr with tensorstore when zarr-python is unavailable? |
Sure. Currently the test case will cover using both drivers, if we want to test this scenario we need a separate env. I will see how can we do this with github CI. |
No description provided.