Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not add protocol-gRPC when sending a request from docs client (#5124)
Motivation: I miss Armeria docs service a lot. So I am working on an implementation of the server side in Go to be able to reuse the excellent client :) https://github.com/curioswitch/go-docs-handler/blob/main/examples/connect/main.go Currently still WIP, the features of simple GreetService are implemented but still just a bit more work to finish it up. Normally I would wait until more completeness but I saw the "Update dependencies" PR :P `protocol=gRPC` is added for better differentiation within the docs UI but is not necessary for actually making requests. Coincidentally, not including it provides compatibility with this Go gRPC server implementation called connect. While I doubt Armeria could officially implement servers in other languages / frameworks like this, may small best effort tweaks are still ok? Modifications: - Don't send gRPC=protocol in the actual request to a gRPC service - Also added a logging statement when parsing a specification fails, currently it is completely squashed and hard to debug server side issues Result: Go API developers (and maybe other languages that take a similar approach) can take advantage of some of Armeria's awesomeness. <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
- Loading branch information