Skip to content

Commit

Permalink
Fix Jacoco failure (#5994)
Browse files Browse the repository at this point in the history
Motivation:

```
Caused by: java.lang.IllegalStateException: Can't add different class with same name: com/linecorp/armeria/common/logback/LoggingEventWrapper
	at org.jacoco.core.analysis.CoverageBuilder.visitCoverage(CoverageBuilder.java:106)
	at org.jacoco.core.analysis.Analyzer$1.visitEnd(Analyzer.java:100)
	at org.objectweb.asm.ClassVisitor.visitEnd(ClassVisitor.java:395)
	at org.jacoco.core.internal.flow.ClassProbesAdapter.visitEnd(ClassProbesAdapter.java:100)
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:749)
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:425)
	at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:117)
	at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:133)
	... 152 more
```

Modifications:

- Set `no_aggregation` flag to `:it:logback1.5`

Result:

Fixes #5989
  • Loading branch information
ikhoon authored Nov 21, 2024
1 parent 79112f5 commit 6af3a6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ includeWithFlags ':it:jackson-provider', 'java', 'relocate
includeWithFlags ':it:kotlin', 'java', 'relocate', 'kotlin'
includeWithFlags ':it:kubernetes-chaos-tests', 'java', 'relocate'
includeWithFlags ':it:logback1.4', 'java11', 'relocate'
includeWithFlags ':it:logback1.5', 'java11', 'relocate'
includeWithFlags ':it:logback1.5', 'java11', 'relocate', 'no_aggregation'
includeWithFlags ':it:multipart', 'java17', 'relocate'
includeWithFlags ':it:nio', 'java', 'relocate'
includeWithFlags ':it:okhttp', 'java', 'relocate'
Expand Down

0 comments on commit 6af3a6c

Please sign in to comment.