Introduce AccessLogWriterUtil and Remove Unnecessary RequestContext Push/Pop #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzfeng2020
changed the title
yzfeng2020
changed the title
yzfeng2020
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
minwoox
approved these changes
Nov 18, 2024
core/src/main/java/com/linecorp/armeria/server/logging/AccessLogWriter.java
Outdated
Show resolved
Hide resolved
ikhoon
reviewed
Nov 18, 2024
core/src/main/java/com/linecorp/armeria/server/ServiceConfig.java
Outdated
Show resolved
Hide resolved
yzfeng2020
force-pushed
the
unnecessary-push-access-logging
branch
from
ecaaa5f
to
912046f
Compare
yzfeng2020
changed the title
ikhoon
reviewed
Nov 19, 2024
core/src/main/java/com/linecorp/armeria/server/logging/AccessLogWriter.java
Outdated
Show resolved
Hide resolved
ikhoon
approved these changes
Nov 19, 2024
minwoox
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ush/Pop (#5985) Motivation: As described in #5984, there are instances of unnecessary request context push/pop operations related to access logging when the access log writer is disabled. These operations are redundant since the logging path does not need to be triggered when the writer is disabled. Optimizing this behavior reduces unnecessary overhead in such cases. Modifications: - Added `AccessLogWriterUtil#maybeWriteAccessLog` - Writes access log only when `TransientServiceOption#WITH_ACCESS_LOGGING` is enabled and the access log writer is not disabled. - Updated `AbstractHttpResponseHandler` and `HttpServerHandler` Result: - Closes #5984. - Removes unnecessary context push/pop operations for access logging when the access log writer is disabled, resulting in a more efficient request handling process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As described in #5984, there are instances of unnecessary request context push/pop operations related to access logging when the access log writer is disabled. These operations are redundant since the logging path does not need to be triggered when the writer is disabled. Optimizing this behavior reduces unnecessary overhead in such cases.
Modifications:
AccessLogWriterUtil#maybeWriteAccessLogTransientServiceOption#WITH_ACCESS_LOGGINGis enabled and the access log writer is not disabled.AbstractHttpResponseHandlerandHttpServerHandlerResult: