Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the default HealthCheckUpdateHandler #6002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Expose the default HealthCheckUpdateHandler #6002

wants to merge 2 commits into from

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Nov 26, 2024

Motivation:

When implementing a custom HealthCheckUpdateHandler, I just wanted to add validation in front of the default implementation. However, it wasn't possible because the default implementation has package-private visibility.

Modifications:

  • Expose the default HealthCheckUpdateHandler via HealthCheckUpdateHandler.of()

Result:

You can now use the default HealthCheckUpdateHandler via HealthCheckUpdateHandler.of()

@ikhoon
Expose the default HealthCheckUpdateHandler
e40b984 
Motivation:

When implementing a custom `HealthCheckUpdateHandler`, I just wanted to
add validation in front of the default implementation. However, it
wasn't possible because the default implementation has package-private
visibility.

Modifications:

- Expose the default `HealthCheckUpdateHandler` via `HealthCheckUpdateHandler.of()`

Result:

You can now use the default `HealthCheckUpdateHandler` via `HealthCheckUpdateHandler.of()`
@ikhoon ikhoon added this to the 1.32.0 milestone Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

🔍 Build Scan® (commit: a1fc0a2)

Job name Status Build Scan®
build-ubicloud-standard-8-jdk-8 ✅ https://ge.armeria.dev/s/bqeg2cn7rhg76
build-ubicloud-standard-8-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/bwlzr3n4pmo7s
build-ubicloud-standard-8-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/kebqbzkkbigsu
build-ubicloud-standard-8-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/57ifnmtswfk5c
build-ubicloud-standard-8-jdk-17-leak ✅ https://ge.armeria.dev/s/5xxbor66zxjnw
build-ubicloud-standard-8-jdk-11 ✅ https://ge.armeria.dev/s/zvhrjsih6oxqy
build-macos-12-jdk-21 ✅ https://ge.armeria.dev/s/fyqjtz6w7uvt2

minwoox
minwoox approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@jrhee17 jrhee17 Awaiting requested review from jrhee17 jrhee17 is a code owner

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ikhoon @minwoox