Skip to content

Blockhound: Allow blocking call in kubernetes-client WatchEventsListener #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Blockhound: Allow blocking call in kubernetes-client WatchEventsListener #6287

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a000801
Allow blocking call in kubernetes-client `WatchEventsListener`
sh-cho Jun 20, 2025
ea367c5
Add `KubernetesTestBlockHoundIntegration`
sh-cho Jul 1, 2025
ca2d85a
Add license header
sh-cho Jul 1, 2025
d432271
Add allowing blocking call `onFailure`
sh-cho Jul 1, 2025
8c78e0b
WIP
minwoox Jul 3, 2025
a8fc287
WIP
minwoox Jul 3, 2025
43cf415
Add vert.x-internal-blocking
minwoox Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ...src/main/java/com/linecorp/armeria/client/kubernetes/KubernetesBlockHoundIntegration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,8 @@ public void applyTo(Builder builder) {
// a fully readable ByteBuffer.
builder.allowBlockingCallsInside(
"io.fabric8.kubernetes.client.http.HttpClientReadableByteChannel", "doLockedAndSignal");
// StandardHttpRequest creates UUIDs using java.util.UUID.randomUUID() that uses SecureRandom.
// The method is temporarily allowed until the problem is resolved in the upstream.
// See: https://github.com/fabric8io/kubernetes-client/issues/5735
// TODO(ikhoon): Remove this once the issue is fixed.
// This only used in mock server.
builder.allowBlockingCallsInside(
"io.fabric8.kubernetes.client.http.StandardHttpRequest$Builder",
"build");
"io.fabric8.kubernetes.client.server.mock.WatchEventsListener", "onClosed");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, but I’d prefer not to add test-related code into the production codebase. What do you think about introducing a separate KubernetesTestBlockHoundIntegration class under the test directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good :)
I will try it

}
}
Loading