This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
X11: make clone cheap #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove a couple of Rc<..> wrappers which are no longer required.
|
Yes it works, aside from a hang at exit (#50) I think if Glazier is to be a cross-platform windowing library, it should support X11. Even with Wayland set to replace it, X11 will be around for years... |
jneem
approved these changes
Jan 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other
Applicationobjects are cheap to clone. The X11 one had quite a lot of fields.This probably doesn't have a big impact anywhere; it was on the path to trying to fix another bug...