-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera ready #43
base: main
Are you sure you want to change the base?
Camera ready #43
Conversation
Apply acmauthoryear cite style as requested. Small changes to the figures, making lines bolder and adding axis labels. Also add a mention to the Vello rendering engine, which was missing due to anonymity.
%\conferenceinfo{Foo}{Month Day-Day, Year, Location} | ||
\copyrightyear{2024} | ||
\setcopyright{acmcopyright} | ||
%\conferenceinfo{High Performance Graphics}{July 26-28 2024, Denver} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That macro is not defined in the template, so uncommenting it causes an error. I believe the metadata is set correctly now, see eaac725.
This applies the DOI and the rights statement as appropriate for publication in PACMCGIT.
Use a vector rendering of the original Nimbus 'g' in the figure, rather than a bitmap. Visually it is very similar, just crisper.
Marking as ready to review, as this is the exact version sent to ACM. There's a short window yet to make revisions, but I believe we should consider this the final version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest notes from Stephen:
Please add your e-mail addresses using the \email{} command.
The headers and footers are missing, and there are page numbers.
Include \citestyle{acmauthoryear} in the preamble.
Algorithm 2 exceeds the page margins (at the bottom).
Yep, working on those notes. Some are straightforward, we need |
Use acmauthoryear cite style. Add email addresses. Squash linespace of algorithm 2 to fit page margins. With this cite style, the `\citenum` command is no longer valid, so those are all changed to `\cite`. There are a number of instances that use `\citet` with the author specified in the text, and I believe those are compliant, but I'm not sure that's best. It's possible those should be edited to `\cite` so the author is inside the brackets.
Just use `\cite` for all citations, as there's no longer a need to distinguish `\citenum` from `\citet`. Minor text edits have been made to make this consistent, and the authors of a couple corporately authored artifacts have been changed to mangle the names less.
This is a working draft of the "camera ready" version. The final document numbers will be added on the ACM side.
I think this is submittable as is. One thing I see that I would like to address is the bitmap "g" in Fig 8. Also, I'm not completely satisfied with Fig 11, but I might call it "good enough."