Update to Vello 0.3, Peniko 0.2 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorgy
approved these changes
Dec 18, 2024
xorgy
reviewed
Dec 18, 2024
DJMcNab
reviewed
Dec 18, 2024
| @@ -407,7 +407,7 @@ impl Brush { | |||
| /// Evaluates the animation at the specified time. | |||
| pub fn evaluate(&self, alpha: f64, frame: f64) -> fixed::Brush { | |||
| match self { | |||
| Self::Solid(value) => value.evaluate(frame).with_alpha_factor(alpha as f32).into(), | |||
| Self::Solid(value) => value.evaluate(frame).multiply_alpha(alpha as f32).into(), | |||
| Self::Gradient(value) => value.evaluate(frame), | |||
There was a problem hiding this comment.
Should this have multiply_alpha here as well?
(The other question is, why is alpha a parameter to this function at all?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.