Conversation
DJMcNab
approved these changes
Feb 10, 2025
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Updating maud is good, but we will need to follow-up to update the rest of the dependency specifications.
kompari-html/Cargo.toml
Outdated
| maud = "0.27" | ||
| imagesize = "0.13" | ||
| serde = { version = "1.0.217", features = ["derive"] } | ||
| serde = { version = "1", features = ["derive"] } |
Member
There was a problem hiding this comment.
Our policy in Linebender is to generally give "precise" bounds on dependencies. See linebender/rfcs#5
So this should still be 1.0.217, etc.
Collaborator
Author
There was a problem hiding this comment.
Returned "1.0.217"
| serde = { version = "1.0.217", features = ["derive"] } | ||
| serde = { version = "1", features = ["derive"] } | ||
| tokio = "1.43" | ||
| axum = "0.8" No newline at end of file |
Member
There was a problem hiding this comment.
We probably should add formatting using Taplo here (see linebender/vello#809)
This again shouldn't happen in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.