Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.11.1 #374

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Release 0.11.1 #374

merged 1 commit into from
Sep 12, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

Tentatively thinking about Monday, September 2. This is blocked on #372 and #373. Not sure that we'll get #350 in or not, but we can always cut a new release sooner rather than later.

@DJMcNab
Copy link
Member

DJMcNab commented Sep 2, 2024

Going through the commits in this release, whilst reviewing #373.

Could #340 be breaking? I think probably technically yes, but practically it requires writing adversarial code to do so.
Are #361/#370 breaking? I think the worst case is it breaks end-user CI when they are using -D warnings, and not using a Cargo.lock, so it's probably fine.

@waywardmonkeys
Copy link
Contributor Author

Re: #340, there was a consensus at the time that it wasn't. I also think I checked with the author of semver-checks and he agreed not breaking.

Re: #361 / #370: By convention, this is not breaking.

@waywardmonkeys waywardmonkeys force-pushed the release-0.11.1 branch 2 times, most recently from fce1791 to a12a10a Compare September 9, 2024 07:17
@waywardmonkeys waywardmonkeys marked this pull request as ready for review September 9, 2024 08:59
DJMcNab
DJMcNab reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this landed, although I can't formally approve due to lacking publish rights on Kurbo.

The actual code changes in this PR are correct.

@xorgy xorgy added this pull request to the merge queue Sep 12, 2024
Merged via the queue into linebender:main with commit d948d1e Sep 12, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the release-0.11.1 branch September 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab left review comments

@xorgy xorgy xorgy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @DJMcNab @xorgy