Skip to content

Fix handling of line break overrides before newlines #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DJMcNab merged 1 commit into from
Jul 7, 2026
Merged

Fix handling of line break overrides before newlines #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion parley_core/src/break_overrides.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ fn chromium_override(cx: LineBreakContext) -> Option<bool> {
//
// Note that we'd need different handling in the `after == ' '` case if we ever get the equivalent of
// CSS's whitespace-collapse: break-spaces.
if before == ' ' && after != ' ' {
if before == ' ' && after != ' '
// Mandatory break characters. A soft wrap opportunity is never valid
// immediately before one (see UAX-14 rule LB6).
&& !matches!(after, '\n' | '\u{0B}' | '\u{0C}' | '\r' | '\u{85}' | '\u{2028}' | '\u{2029}')
{
return Some(true);
}
// Before consulting 'before' / 'after' pair table, check for the special "-" case.
Expand Down
Loading