[fontique] use windows-rs for dwrite backend #85
Conversation
Swaps out winapi, wio and dwrote for windows-core and windows.
| i += 1; | ||
| .is_ok() | ||
| { | ||
| if let Some(font) = mapped_font { |
There was a problem hiding this comment.
What happens if there isn't a mapped font? I assume falling through to None case is fine, but the mapped_len doesn't seem to be used, instead just skipping a single character.
There was a problem hiding this comment.
In reality, we’re not making full use of this function. What we actually want is the font DirectWrite would choose for a specific Unicode script and locale. Since there’s no API for this, we cheat by using a table containing sample text for each script (see
Line 90 in caabcf1
Ideally, we’d hand curate the sample table for comprehensive coverage, but so far it’s seemed to work on all platforms (with some tiny hacks like this one) so I haven’t bothered.
There was a problem hiding this comment.
That's a great explanation and a subset of this would be a great thing to have in a comment in this code. :)
There was a problem hiding this comment.
Fair point! I’ll add a comment describing this glorious hack to hopefully avoid confusion for future readers.
Swaps out winapi, wio and dwrote for windows-core and windows.